Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "don't invalidate preloaded cache on checkout close events" #47

Merged
merged 1 commit into from
Nov 2, 2023
Merged

Revert "don't invalidate preloaded cache on checkout close events" #47

merged 1 commit into from
Nov 2, 2023

Conversation

cianbuckley
Copy link
Contributor

@cianbuckley cianbuckley commented Nov 2, 2023 •
edited
Loading

We in fact, do want to invalidate cache on didCancel events. This is to prevent the following scenario:

  • merchant dev does not call preload, but preload is enabled by default
  • user of merchant app adds item to cart
  • user views checkout
  • user closes checkout to return to cart
  • user adds new item
  • user returns to cart, but preload was never called in merchant side code therefore never refreshes cached checkout

Reverts #46

@cianbuckley cianbuckley requested a review from a team as a code owner November 2, 2023 16:41
@cianbuckley cianbuckley requested a review from markmur November 2, 2023 16:42
@cianbuckley cianbuckley merged commit cdd597e into main Nov 2, 2023
4 checks passed
@cianbuckley cianbuckley deleted the revert-46-dont-invalidate-cache-on-close branch November 2, 2023 16:50
markmur pushed a commit that referenced this pull request Nov 7, 2023
@cianbuckley @markmur
Revert "don't invalidate preloaded cache on checkout close events (#46)…
9fe504a 
…" (#47)

This reverts commit ddf153f.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@markmur markmur markmur approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cianbuckley @markmur